Issue 14259002: Fix dartc tests and pub after IOSink change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14259002: Fix dartc tests and pub after IOSink change. (Closed)

Created:
7 years, 8 months ago by Anders Johnsen

Modified:
7 years, 8 months ago

Reviewers:
nweiz, Søren Gjesse

CC:
reviews_dartlang.org, nweiz

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix dartc tests and pub after IOSink change. BUG= Committed: https://code.google.com/p/dart/source/detail?r=21420

Patch Set 2 : #

Total comments: 2

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -4 lines)			Patch
M	samples/build_dart/build.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	samples/build_dart_simple/build.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	utils/pub/io.dart	View	1 chunk	+2 lines, -2 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

Committed patchset #2 manually as r21420 (presubmit successful).

7 years, 8 months ago (2013-04-15 08:26:10 UTC) #2

nweiz

https://codereview.chromium.org/14259002/diff/2001/utils/pub/io.dart File utils/pub/io.dart (right): https://codereview.chromium.org/14259002/diff/2001/utils/pub/io.dart#newcode295 utils/pub/io.dart:295: EventSink<List<int>> _wrapStdio(IOSink sink, String name) { This is no ...

7 years, 8 months ago (2013-04-15 19:37:23 UTC) #3

nweiz

7 years, 8 months ago (2013-04-15 19:59:52 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/14259002/diff/2001/utils/pub/io.dart
File utils/pub/io.dart (right):

https://codereview.chromium.org/14259002/diff/2001/utils/pub/io.dart#newcode295
utils/pub/io.dart:295: EventSink<List<int>> _wrapStdio(IOSink sink, String name)
{
On 2013/04/15 19:37:23, nweiz wrote:
> This is no longer used; you can remove it.

I hadn't seen the second CL when I wrote this. I'll take care of transitioning
pub to the IOSink API.

Expand Messages | Collapse Messages

Issue 14259002: Fix dartc tests and pub after IOSink change. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages