Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 14258009: svg and json tests: fixing nested test calls (Closed)

Created:
7 years, 8 months ago by kevmoo-old
Modified:
7 years, 8 months ago
Reviewers:
Emily Fortuna, sra1, blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

svg and json tests: fixing nested test calls Committed: https://code.google.com/p/dart/source/detail?r=21678

Patch Set 1 #

Patch Set 2 : similiar bug in json_test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tests/html/svgelement_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/json/json_test.dart View 1 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
kevmoo-old
testConstructor wraps a call to test() is great, but that means it should not be ...
7 years, 8 months ago (2013-04-18 15:26:02 UTC) #1
kevmoo-old
Found another case of tests within test in json_test
7 years, 8 months ago (2013-04-18 15:48:28 UTC) #2
blois
lgtm
7 years, 8 months ago (2013-04-18 15:52:44 UTC) #3
kevmoo-old
7 years, 8 months ago (2013-04-18 16:20:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r21678 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698