Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 14253008: Optimize length access on all JSIndexable things. (Closed)

Created:
7 years, 8 months ago by kasperl
Modified:
7 years, 8 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Optimize length access on all JSIndexable things. R=ngeoffray@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=21918

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -45 lines) Patch
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 2 chunks +9 lines, -14 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/interceptors.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/codegen.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/optimize.dart View 6 chunks +18 lines, -24 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js/value_range_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/utils/dummy_compiler_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/utils/recursive_import_test.dart View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kasperl
7 years, 8 months ago (2013-04-23 14:14:12 UTC) #1
ngeoffray
LGTM! https://codereview.chromium.org/14253008/diff/1/sdk/lib/_internal/compiler/implementation/ssa/optimize.dart File sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (right): https://codereview.chromium.org/14253008/diff/1/sdk/lib/_internal/compiler/implementation/ssa/optimize.dart#newcode329 sdk/lib/_internal/compiler/implementation/ssa/optimize.dart:329: if (selector.asUntyped.applies(backend.jsIndexableLength, compiler)) { As discussed, you could ...
7 years, 8 months ago (2013-04-23 14:23:40 UTC) #2
kasperl
7 years, 8 months ago (2013-04-24 05:36:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r21918 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698