Lint to test for private/implementation imports.

Lint to test for private/implementation imports.

Background here: https://github.com/dart-lang/linter/issues/36

R=brianwilkerson@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/linter/commit/c62ec70b78c716d5ffb850b82344b88a5cd7c609

[pquitslund, 2015-10-31 20:44:51]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[Brian Wilkerson, 2015-10-31 21:04:30]

LGTM

https://codereview.chromium.org/1425293002/diff/1/lib/src/rules/implementatio...
File lib/src/rules/implementation_imports.dart (right):

https://codereview.chromium.org/1425293002/diff/1/lib/src/rules/implementatio...
lib/src/rules/implementation_imports.dart:73: LintRule rule;
Make 'rule' final?

https://codereview.chromium.org/1425293002/diff/1/test/rule_test.dart
File test/rule_test.dart (right):

https://codereview.chromium.org/1425293002/diff/1/test/rule_test.dart#newcode70
test/rule_test.dart:70: var uris2 = [Uri.parse('foo/bar.dart'),
Uri.parse('src/bar.dart')];
Include a non-package, but absolute, URI (such as "dart:async")?

https://codereview.chromium.org/1425293002/diff/1/test/rules/implementation_i...
File test/rules/implementation_imports.dart (right):

https://codereview.chromium.org/1425293002/diff/1/test/rules/implementation_i...
test/rules/implementation_imports.dart:5: // Tested in unit tests.
What is the purpose of this file?

[scheglov, 2015-10-31 21:25:12]

LGTM

https://codereview.chromium.org/1425293002/diff/1/lib/src/rules/implementatio...
File lib/src/rules/implementation_imports.dart (right):

https://codereview.chromium.org/1425293002/diff/1/lib/src/rules/implementatio...
lib/src/rules/implementation_imports.dart:49: bool isPackage(Uri uri) =>
uri?.scheme == 'package' ?? false;
I think "?? false" is not necessary, because null == 'package' already gives
"false".

[pquitslund, 2015-10-31 23:13:09]

Thanks!

https://codereview.chromium.org/1425293002/diff/1/lib/src/rules/implementatio...
File lib/src/rules/implementation_imports.dart (right):

https://codereview.chromium.org/1425293002/diff/1/lib/src/rules/implementatio...
lib/src/rules/implementation_imports.dart:49: bool isPackage(Uri uri) =>
uri?.scheme == 'package' ?? false;
On 2015/10/31 21:25:12, scheglov wrote:
> I think "?? false" is not necessary, because null == 'package' already gives
> "false".

Spot on.  I extracted this method and missed that it was no longer needed.
Fixed. Thanks!

https://codereview.chromium.org/1425293002/diff/1/lib/src/rules/implementatio...
lib/src/rules/implementation_imports.dart:73: LintRule rule;
On 2015/10/31 21:04:30, Brian Wilkerson wrote:
> Make 'rule' final?

Done.  Aside: I'm puzzled as to why I haven't done this for for rule visitors as
I'm usually such a stickler.

Thanks!

https://codereview.chromium.org/1425293002/diff/1/test/rule_test.dart
File test/rule_test.dart (right):

https://codereview.chromium.org/1425293002/diff/1/test/rule_test.dart#newcode70
test/rule_test.dart:70: var uris2 = [Uri.parse('foo/bar.dart'),
Uri.parse('src/bar.dart')];
On 2015/10/31 21:04:30, Brian Wilkerson wrote:
> Include a non-package, but absolute, URI (such as "dart:async")?

Good one.  Done!

https://codereview.chromium.org/1425293002/diff/1/test/rules/implementation_i...
File test/rules/implementation_imports.dart (right):

https://codereview.chromium.org/1425293002/diff/1/test/rules/implementation_i...
test/rules/implementation_imports.dart:5: // Tested in unit tests.
On 2015/10/31 21:04:30, Brian Wilkerson wrote:
> What is the purpose of this file?

Good catch.  I *misremembered* that the test framework was expecting a test for
reach rule and would fail without it.

Removed!

[pquitslund, 2015-10-31 23:13:25]

Committed patchset #2 (id:20001) manually as
c62ec70b78c716d5ffb850b82344b88a5cd7c609 (presubmit successful).