Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14251021: Move invokeOn to InstanceMirror. (Closed)

Created:
7 years, 8 months ago by ahe
Modified:
7 years, 8 months ago
CC:
reviews_dartlang.org, erikcorry, ngeoffray, Ivan Posva, gbracha
Visibility:
Public.

Description

Move invokeOn to InstanceMirror. Committed: https://code.google.com/p/dart/source/detail?r=21636

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -46 lines) Patch
M dart/runtime/lib/invocation_mirror_patch.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M dart/runtime/lib/mirrors_impl.dart View 2 chunks +18 lines, -0 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/compiler.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/lib/interceptors.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart View 2 chunks +6 lines, -1 line 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart View 4 chunks +7 lines, -4 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/sdk/lib/core/invocation.dart View 1 chunk +0 lines, -9 lines 0 comments Download
M dart/sdk/lib/mirrors/mirrors.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M dart/tests/compiler/dart2js_native/native_no_such_method_exception3_frog_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M dart/tests/compiler/dart2js_native/native_no_such_method_exception4_frog_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M dart/tests/compiler/dart2js_native/native_no_such_method_exception5_frog_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M dart/tests/language/field_increment_bailout_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M dart/tests/language/invocation_mirror2_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M dart/tests/language/invocation_mirror_invoke_on2_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M dart/tests/language/invocation_mirror_invoke_on_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M dart/tests/language/many_overridden_no_such_method_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M dart/tests/language/no_such_method_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M dart/tests/language/overridden_no_such_method.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/language/overridden_no_such_method_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M dart/tests/language/super_call4_test.dart View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ahe
7 years, 8 months ago (2013-04-17 15:39:19 UTC) #1
ngeoffray
Non-VM changes LGTM
7 years, 8 months ago (2013-04-17 15:59:58 UTC) #2
regis
VM changes LGTM
7 years, 8 months ago (2013-04-17 16:29:15 UTC) #3
ahe
7 years, 8 months ago (2013-04-17 16:39:43 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 manually as r21636 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698