Change url to uri on LibraryMirror.

Change url to uri on LibraryMirror.

Committed: https://code.google.com/p/dart/source/detail?r=21803

[ahe, 2013-04-15 13:24:48]

https://codereview.chromium.org/14251005/diff/1/runtime/lib/mirrors_impl.dart
File runtime/lib/mirrors_impl.dart (right):

https://codereview.chromium.org/14251005/diff/1/runtime/lib/mirrors_impl.dart...
runtime/lib/mirrors_impl.dart:708: String get url => uri.toString();
Why keep "url"?

https://codereview.chromium.org/14251005/diff/1/sdk/lib/mirrors/mirrors.dart
File sdk/lib/mirrors/mirrors.dart (right):

https://codereview.chromium.org/14251005/diff/1/sdk/lib/mirrors/mirrors.dart#...
sdk/lib/mirrors/mirrors.dart:283: * Deprecated: Use [uri] instead.
Today is a great day to get rid of deprecated stuff :-)

https://codereview.chromium.org/14251005/diff/1/tests/lib/mirrors/mirrors_tes...
File tests/lib/mirrors/mirrors_test.dart (right):

https://codereview.chromium.org/14251005/diff/1/tests/lib/mirrors/mirrors_tes...
tests/lib/mirrors/mirrors_test.dart:104: path: appendSlash(new Path(new
File('.').fullPathSync()).toString()));
I'd be more comfortable if this test didn't require dart:io.  Could you test
that the path of the uri ends with '/mirrors_test.dart'?

[Johnni Winther, 2013-04-17 09:40:33]

PTAL

https://codereview.chromium.org/14251005/diff/1/runtime/lib/mirrors_impl.dart
File runtime/lib/mirrors_impl.dart (right):

https://codereview.chromium.org/14251005/diff/1/runtime/lib/mirrors_impl.dart...
runtime/lib/mirrors_impl.dart:708: String get url => uri.toString();
On 2013/04/15 13:24:48, ahe wrote:
> Why keep "url"?

Removed.

https://codereview.chromium.org/14251005/diff/1/sdk/lib/mirrors/mirrors.dart
File sdk/lib/mirrors/mirrors.dart (right):

https://codereview.chromium.org/14251005/diff/1/sdk/lib/mirrors/mirrors.dart#...
sdk/lib/mirrors/mirrors.dart:283: * Deprecated: Use [uri] instead.
On 2013/04/15 13:24:48, ahe wrote:
> Today is a great day to get rid of deprecated stuff :-)

Removed.

https://codereview.chromium.org/14251005/diff/1/tests/lib/mirrors/mirrors_tes...
File tests/lib/mirrors/mirrors_test.dart (right):

https://codereview.chromium.org/14251005/diff/1/tests/lib/mirrors/mirrors_tes...
tests/lib/mirrors/mirrors_test.dart:104: path: appendSlash(new Path(new
File('.').fullPathSync()).toString()));
On 2013/04/15 13:24:48, ahe wrote:
> I'd be more comfortable if this test didn't require dart:io.  Could you test
> that the path of the uri ends with '/mirrors_test.dart'?

Added two tests for testing file and package uris.

[ahe, 2013-04-17 10:47:32]

LGTM! A few nits below.

https://codereview.chromium.org/14251005/diff/8001/tests/lib/mirrors/library_...
File tests/lib/mirrors/library_uri_io_test.dart (right):

https://codereview.chromium.org/14251005/diff/8001/tests/lib/mirrors/library_...
tests/lib/mirrors/library_uri_io_test.dart:7: library MirrorsTest;
Add line between library declaration and imports.

https://codereview.chromium.org/14251005/diff/8001/tests/lib/mirrors/library_...
tests/lib/mirrors/library_uri_io_test.dart:11: import 'dart:uri';
Be consistent with quotes.  Also, I prefer listing dart: imports.

https://codereview.chromium.org/14251005/diff/8001/tests/lib/mirrors/library_...
File tests/lib/mirrors/library_uri_package_test.dart (right):

https://codereview.chromium.org/14251005/diff/8001/tests/lib/mirrors/library_...
tests/lib/mirrors/library_uri_package_test.dart:5: // TODO(rmacnak): Move the
existing mirror tests here (a place for
?

https://codereview.chromium.org/14251005/diff/8001/tests/lib/mirrors/library_...
tests/lib/mirrors/library_uri_package_test.dart:8: library MirrorsTest;
Add a line?

https://codereview.chromium.org/14251005/diff/8001/tests/lib/mirrors/library_...
tests/lib/mirrors/library_uri_package_test.dart:12: import
'package:args/args.dart';
Quotes and order.

https://codereview.chromium.org/14251005/diff/8001/tests/lib/mirrors/mirrors_...
File tests/lib/mirrors/mirrors_test.dart (right):

https://codereview.chromium.org/14251005/diff/8001/tests/lib/mirrors/mirrors_...
tests/lib/mirrors/mirrors_test.dart:135: (Uri uri) =>
uri.path.endsWith('mirrors_test.dart'));
Add leading slash?

[Johnni Winther, 2013-04-22 09:27:18]

https://codereview.chromium.org/14251005/diff/8001/tests/lib/mirrors/library_...
File tests/lib/mirrors/library_uri_io_test.dart (right):

https://codereview.chromium.org/14251005/diff/8001/tests/lib/mirrors/library_...
tests/lib/mirrors/library_uri_io_test.dart:7: library MirrorsTest;
On 2013/04/17 10:47:32, ahe wrote:
> Add line between library declaration and imports.

Done.

https://codereview.chromium.org/14251005/diff/8001/tests/lib/mirrors/library_...
tests/lib/mirrors/library_uri_io_test.dart:11: import 'dart:uri';
On 2013/04/17 10:47:32, ahe wrote:
> Be consistent with quotes.  Also, I prefer listing dart: imports.

Done.

https://codereview.chromium.org/14251005/diff/8001/tests/lib/mirrors/library_...
File tests/lib/mirrors/library_uri_package_test.dart (right):

https://codereview.chromium.org/14251005/diff/8001/tests/lib/mirrors/library_...
tests/lib/mirrors/library_uri_package_test.dart:5: // TODO(rmacnak): Move the
existing mirror tests here (a place for
On 2013/04/17 10:47:32, ahe wrote:
> ?

Removed.

https://codereview.chromium.org/14251005/diff/8001/tests/lib/mirrors/library_...
tests/lib/mirrors/library_uri_package_test.dart:8: library MirrorsTest;
On 2013/04/17 10:47:32, ahe wrote:
> Add a line?

Done.

https://codereview.chromium.org/14251005/diff/8001/tests/lib/mirrors/library_...
tests/lib/mirrors/library_uri_package_test.dart:12: import
'package:args/args.dart';
On 2013/04/17 10:47:32, ahe wrote:
> Quotes and order.

Done.

https://codereview.chromium.org/14251005/diff/8001/tests/lib/mirrors/mirrors_...
File tests/lib/mirrors/mirrors_test.dart (right):

https://codereview.chromium.org/14251005/diff/8001/tests/lib/mirrors/mirrors_...
tests/lib/mirrors/mirrors_test.dart:135: (Uri uri) =>
uri.path.endsWith('mirrors_test.dart'));
On 2013/04/17 10:47:32, ahe wrote:
> Add leading slash?

Done.

[Johnni Winther, 2013-04-22 10:28:38]

Committed patchset #5 manually as r21803 (presubmit successful).