Revise based on feedback from previous patch.

Revise based on feedback from previous patch.

Committed: https://code.google.com/p/dart/source/detail?r=21644

[nweiz, 2013-04-17 00:59:55]

https://codereview.chromium.org/14249006/diff/1/utils/pub/solver/backtracking...
File utils/pub/solver/backtracking_solver.dart (right):

https://codereview.chromium.org/14249006/diff/1/utils/pub/solver/backtracking...
utils/pub/solver/backtracking_solver.dart:197: var currentPath = depender.name;
I think my comment on this may have been swallowed last time, but it's confusing
that you're modifying this variable in [walkDeps]. It would be a lot cleaner to
just pass in a `String path` parameter.

[Bob Nystrom, 2013-04-17 17:11:03]

Thanks!

https://codereview.chromium.org/14249006/diff/1/utils/pub/solver/backtracking...
File utils/pub/solver/backtracking_solver.dart (right):

https://codereview.chromium.org/14249006/diff/1/utils/pub/solver/backtracking...
utils/pub/solver/backtracking_solver.dart:197: var currentPath = depender.name;
On 2013/04/17 00:59:55, nweiz wrote:
> I think my comment on this may have been swallowed last time, but it's
confusing
> that you're modifying this variable in [walkDeps]. It would be a lot cleaner
to
> just pass in a `String path` parameter.

Oh, now I see. I read that earlier comment as just being about the other
resultPath variable. You're exactly right that your suggestion is cleaner.
Fixed.

[nweiz, 2013-04-17 18:28:56]

lgtm

[Bob Nystrom, 2013-04-17 18:36:37]

Committed patchset #2 manually as r21644 (presubmit successful).