Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 14247026: Disable SDK constraint checking on bleeding edge. (Closed)

Created:
7 years, 8 months ago by Bob Nystrom
Modified:
7 years, 8 months ago
Reviewers:
nweiz, dgrove
CC:
reviews_dartlang.org, devoncarew, keertip
Visibility:
Public.

Description

Disable SDK constraint checking on bleeding edge. BUG= Committed: https://code.google.com/p/dart/source/detail?r=21773

Patch Set 1 #

Patch Set 2 : Add test. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -2 lines) Patch
M utils/pub/sdk.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M utils/pub/solver/backtracking_solver.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M utils/tests/pub/command_line_config.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/version_solver_test.dart View 1 3 chunks +21 lines, -1 line 2 comments Download

Messages

Total messages: 4 (0 generated)
Bob Nystrom
This should fix the OOM you're getting if you run pub from bleeding_edge. Sorry I ...
7 years, 8 months ago (2013-04-19 17:22:23 UTC) #1
nweiz
lgtm https://codereview.chromium.org/14247026/diff/1003/utils/tests/pub/version_solver_test.dart File utils/tests/pub/version_solver_test.dart (right): https://codereview.chromium.org/14247026/diff/1003/utils/tests/pub/version_solver_test.dart#newcode698 utils/tests/pub/version_solver_test.dart:698: }); I would find it a little cleaner ...
7 years, 8 months ago (2013-04-19 18:42:07 UTC) #2
Bob Nystrom
https://codereview.chromium.org/14247026/diff/1003/utils/tests/pub/version_solver_test.dart File utils/tests/pub/version_solver_test.dart (right): https://codereview.chromium.org/14247026/diff/1003/utils/tests/pub/version_solver_test.dart#newcode698 utils/tests/pub/version_solver_test.dart:698: }); On 2013/04/19 18:42:07, nweiz wrote: > I would ...
7 years, 8 months ago (2013-04-19 21:13:04 UTC) #3
Bob Nystrom
7 years, 8 months ago (2013-04-19 21:13:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r21773 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698