Add flag --check-function-fingerprints, it checks all function fingerprints of the intrinsifier and…

Add flag --check-function-fingerprints, it checks all function fingerprints of the intrinsifier and method recognizer. Added flag to a test so that the fingerprints will be tested during a regular test.

Committed: https://code.google.com/p/dart/source/detail?r=21711

[hausner, 2013-04-18 22:36:46]

DBC: Would be nice to get output that can be fed into sed to update fingerprints
in the source code automatically.

s/X/Y/

with X begin old FP, Y the new FP.

https://codereview.chromium.org/14247005/diff/9001/tests/language/bootstrap_t...
File tests/language/bootstrap_test.dart (right):

https://codereview.chromium.org/14247005/diff/9001/tests/language/bootstrap_t...
tests/language/bootstrap_test.dart:18: BootstrapTest.testMain();
A chance to update this pattern from early Dash days?

[siva, 2013-04-18 22:48:32]

LGTM with latest update which would run
RECOGNIZED_LIST on all the libraries.

https://codereview.chromium.org/14247005/diff/5001/runtime/vm/object.h
File runtime/vm/object.h (right):

https://codereview.chromium.org/14247005/diff/5001/runtime/vm/object.h#newcod...
runtime/vm/object.h:2192: // Checks function fingerprints. Prints mismatches and
aborts if
and abort if.....

https://codereview.chromium.org/14247005/diff/4009/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/14247005/diff/4009/runtime/vm/object.cc#newco...
runtime/vm/object.cc:6891: }                                                    
                       \
I am wondering if you should be using Symbols::New instead of String::New in all
the cases above because they would already be symbols.

[srdjan, 2013-04-18 22:58:19]

On 2013/04/18 22:36:46, hausner wrote:
> DBC: Would be nice to get output that can be fed into sed to update
fingerprints
> in the source code automatically.
> 
> s/X/Y/

Implemented: before stopping print all substitution commands.
> 
> with X begin old FP, Y the new FP.
> 
>
https://codereview.chromium.org/14247005/diff/9001/tests/language/bootstrap_t...
> File tests/language/bootstrap_test.dart (right):
> 
>
https://codereview.chromium.org/14247005/diff/9001/tests/language/bootstrap_t...
> tests/language/bootstrap_test.dart:18: BootstrapTest.testMain();
> A chance to update this pattern from early Dash days?

[srdjan, 2013-04-18 23:00:43]

https://codereview.chromium.org/14247005/diff/5001/runtime/vm/object.h
File runtime/vm/object.h (right):

https://codereview.chromium.org/14247005/diff/5001/runtime/vm/object.h#newcod...
runtime/vm/object.h:2192: // Checks function fingerprints. Prints mismatches and
aborts if
On 2013/04/18 22:48:33, siva wrote:
> and abort if.....

Discussed, leaving as it is.

https://codereview.chromium.org/14247005/diff/4009/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/14247005/diff/4009/runtime/vm/object.cc#newco...
runtime/vm/object.cc:6891: }                                                    
                       \
On 2013/04/18 22:48:33, siva wrote:
> I am wondering if you should be using Symbols::New instead of String::New in
all
> the cases above because they would already be symbols.

Done.

[srdjan, 2013-04-18 23:18:20]

Committed patchset #8 manually as r21711 (presubmit successful).

[Ivan Posva, 2013-04-23 12:19:30]

https://codereview.chromium.org/14247005/diff/13009/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

https://codereview.chromium.org/14247005/diff/13009/runtime/include/dart_api....
runtime/include/dart_api.h:2449: * Check that all function fingerprints are OK.
I have a hard time understanding why we had to pollute the Dart API for an
internal check like this. Rather we should move in the other direction getting
rid of Dart_CompilerAll() in the embedders API.