Issue 14246039: Implements features to run "Hello, world!" on simulated MIPS.

Issue 14246039: Implements features to run "Hello, world!" on simulated MIPS. (Closed)

Created:
7 years, 8 months ago by zra

Modified:
7 years, 8 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Implements features to run "Hello, world!" on simulated MIPS. Committed: https://code.google.com/p/dart/source/detail?r=21759

Patch Set 2 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1165 lines, -138 lines)			Patch
M	runtime/bin/gen_snapshot.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	runtime/vm/assembler_mips.h	View	1	2 chunks	+44 lines, -36 lines	0 comments	Download
M	runtime/vm/assembler_mips.cc	View	1	2 chunks	+13 lines, -0 lines	0 comments	Download
M	runtime/vm/class_finalizer.cc	View		2 chunks	+0 lines, -5 lines	0 comments	Download
M	runtime/vm/constants_mips.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/dart.cc	View		1 chunk	+1 line, -5 lines	0 comments	Download
M	runtime/vm/disassembler_mips.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_mips.cc	View	1	30 chunks	+53 lines, -8 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1	35 chunks	+555 lines, -47 lines	0 comments	Download
M	runtime/vm/simulator_mips.cc	View		2 chunks	+11 lines, -2 lines	0 comments	Download
M	runtime/vm/stub_code_mips.cc	View	1	32 chunks	+483 lines, -30 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://codereview.chromium.org/14246039/diff/1/runtime/vm/flow_graph_compiler_mips.cc File runtime/vm/flow_graph_compiler_mips.cc (right): https://codereview.chromium.org/14246039/diff/1/runtime/vm/flow_graph_compiler_mips.cc#newcode69 runtime/vm/flow_graph_compiler_mips.cc:69: __ Msg("BoolToJump"); How about TraceSimMsg? Maybe add a ...

7 years, 8 months ago (2013-04-19 18:06:38 UTC) #2

zra

Thanks! https://codereview.chromium.org/14246039/diff/1/runtime/vm/flow_graph_compiler_mips.cc File runtime/vm/flow_graph_compiler_mips.cc (right): https://codereview.chromium.org/14246039/diff/1/runtime/vm/flow_graph_compiler_mips.cc#newcode69 runtime/vm/flow_graph_compiler_mips.cc:69: __ Msg("BoolToJump"); On 2013/04/19 18:06:38, regis wrote: > ...

7 years, 8 months ago (2013-04-19 18:21:54 UTC) #3

zra

7 years, 8 months ago (2013-04-19 18:31:54 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r21759 (presubmit successful).

Expand Messages | Collapse Messages