Issue 14244004: Now that we have host-checked runners, and test.dart disallows multiple "--host_checked" flags, rem…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14244004: Now that we have host-checked runners, and test.dart disallows multiple "--host_checked" flags, rem… (Closed)

Created:
7 years, 8 months ago by ngeoffray

Modified:
7 years, 8 months ago

Reviewers:
ricow1, ahe, kustermann

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Don't add --host-checked twice. Committed: https://code.google.com/p/dart/source/detail?r=21428

Patch Set 3 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	tools/bots/compiler.py	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

Motivated by: http://build.chromium.org/p/client.dart.fyi/builders/dart2js-linux-release-checked-host-checked/builds/988/steps/dart2js_extra%20tests%20--checked%20--host-checked%20--host-checked/logs/stdio

7 years, 8 months ago (2013-04-15 08:51:50 UTC) #1

ahe

Please don't submit as is. I'll be in the office in 25 minutes and will ...

7 years, 8 months ago (2013-04-15 08:59:51 UTC) #2

ngeoffray

PTAL. I updated the script according to Peter's suggestion.

7 years, 8 months ago (2013-04-15 11:05:34 UTC) #4

ngeoffray

7 years, 8 months ago (2013-04-15 11:06:05 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r21428 (presubmit successful).

Expand Messages | Collapse Messages

Issue 14244004: Now that we have host-checked runners, and test.dart disallows multiple "--host_checked" flags, rem… (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages