Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 142403004: Analyzer should set exitCode instead of calling exit (Closed)

Created:
6 years, 10 months ago by Cutch
Modified:
6 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Analyzer should set exitCode instead of calling exit. Calling exit doesn't shutdown the isolate. BUG= R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=32369

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M pkg/analyzer/bin/analyzer.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Cutch
6 years, 10 months ago (2014-02-05 23:40:49 UTC) #1
Brian Wilkerson
LGTM
6 years, 10 months ago (2014-02-06 00:29:59 UTC) #2
Cutch
6 years, 10 months ago (2014-02-06 17:24:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r32369 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698