Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 14238036: Improve type optimization reusing the type argument vector of the instantiator (Closed)

Created:
7 years, 8 months ago by regis
Modified:
7 years, 8 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, polux
Visibility:
Public.

Description

Improve type optimization reusing the type argument vector of the instantiator of generic objects: Do not require anymore that the vector be of the same length. A longer vector with a compatible prefix is acceptable. This saves a class id check and length check. We still require that the uninstantiated type argument vector be the identity vector, i.e. consisting only of type parameters with consecutive indices starting at zero. We will relax this requirement in a later change. Committed: https://code.google.com/p/dart/source/detail?r=22062

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+300 lines, -507 lines) Patch
M runtime/vm/code_generator.cc View 4 chunks +33 lines, -55 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 chunk +1 line, -4 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 6 chunks +61 lines, -110 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 6 chunks +64 lines, -113 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 6 chunks +67 lines, -113 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 3 chunks +61 lines, -105 lines 0 comments Download
M runtime/vm/object.h View 2 chunks +8 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
regis
7 years, 8 months ago (2013-04-25 22:45:45 UTC) #1
srdjan
LGTM, I think ;-).
7 years, 8 months ago (2013-04-25 23:05:31 UTC) #2
regis
7 years, 8 months ago (2013-04-26 00:04:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22062 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698