Don't run tests in "packages" directories.

Don't run tests in "packages" directories.

BUG=9866
Committed: https://code.google.com/p/dart/source/detail?r=21384

[Jennifer Messerly, 2013-04-12 19:58:56]

lgtm

[nweiz, 2013-04-12 19:59:25]

Committed patchset #1 manually as r21384 (presubmit successful).

[kevmoo-old, 2013-04-12 20:01:02]

This is a bit scary.

I could imagine someone creating tests in a 'packages' directory somewhere at
some point and having them just not execute.

The only way I could see this being an okay idea would be if there was also a
script or something that made sure no directories named 'packages' get checked
in.

[nweiz, 2013-04-12 20:03:39]

On 2013/04/12 20:01:02, kevmoo wrote:
> This is a bit scary.
> 
> I could imagine someone creating tests in a 'packages' directory somewhere at
> some point and having them just not execute.
> 
> The only way I could see this being an okay idea would be if there was also a
> script or something that made sure no directories named 'packages' get checked
> in.

It's already really dangerous to create 'packages' directories. Pub at least
treats them specially in various ways. The Dart VM treats them specially if
they're next to an entrypoint. Other tools may as well.

It's unfortunate that the language mandates that there be a reserved directory
name, but given that it does, I don't think we should shy away from making it
more reserved.

[Jennifer Messerly, 2013-04-12 20:20:30]

On 2013/04/12 20:03:39, nweiz wrote:
> On 2013/04/12 20:01:02, kevmoo wrote:
> > This is a bit scary.
> > 
> > I could imagine someone creating tests in a 'packages' directory somewhere
at
> > some point and having them just not execute.
> > 
> > The only way I could see this being an okay idea would be if there was also
a
> > script or something that made sure no directories named 'packages' get
checked
> > in.
> 
> It's already really dangerous to create 'packages' directories. Pub at least
> treats them specially in various ways. The Dart VM treats them specially if
> they're next to an entrypoint. Other tools may as well.
> 
> It's unfortunate that the language mandates that there be a reserved directory
> name, but given that it does, I don't think we should shy away from making it
> more reserved.

Right. Also this file only affects code.google.com/p/dart repository, it doesn't
change what third party packages can do. (Although I agree w/ Nathan, it would
be scary to create a "packages" directory)

In the Dart repo, there are plenty of .status filters, so you should always make
sure your test is actually running on the platforms/configurations you expect. I
think this is reasonably well understood, but I don't have many changes in the
Dart repo these days, so I may be wrong.