Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 14223007: Make common file mode and encoding constants available on the top level in dart:io (Closed)

Created:
7 years, 8 months ago by Søren Gjesse
Modified:
7 years, 8 months ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make common file mode and encoding constants available on the top level in dart:io R=ager@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=21335

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -44 lines) Patch
M sdk/lib/io/file.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M sdk/lib/io/string_transformer.dart View 2 chunks +9 lines, -5 lines 0 comments Download
M tests/standalone/io/file_test.dart View 23 chunks +39 lines, -39 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
7 years, 8 months ago (2013-04-12 08:07:58 UTC) #1
Mads Ager (google)
LGTM
7 years, 8 months ago (2013-04-12 08:36:57 UTC) #2
Søren Gjesse
7 years, 8 months ago (2013-04-12 08:39:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21335 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698