Issue 14222009: Fix issue 9844 by adressing additional review comments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14222009: Fix issue 9844 by adressing additional review comments (Closed)

Created:
7 years, 8 months ago by ricow1

Modified:
7 years, 8 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Fix issue 9844 by adressing additional review comments Comments by Peter here should fix it: https://codereview.chromium.org/13812019/ Committed: https://code.google.com/p/dart/source/detail?r=21331

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	sdk/bin/dart2js.bat	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

ahe

Let's change PRODUCT_DIR/dart-sdk to PRODUCT_DIR/dart sdk. Otherwise we won't be testing this and risk breaking ...

7 years, 8 months ago (2013-04-12 07:59:10 UTC) #2

ricow1

7 years, 8 months ago (2013-04-12 08:01:26 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r21331 (presubmit successful).