Issue 14215006: Re-apply r20377.

Issue 14215006: Re-apply r20377. (Closed)

Created:
7 years, 8 months ago by Vyacheslav Egorov (Google)

Modified:
7 years, 8 months ago

Reviewers:
Florian Schneider, Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Re-apply r20377. Compute local variable liveness before translation to SSA. Use it to remove dead values from deoptimization environments. R=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=21439

Patch Set 1 #

Patch Set 2 : Fix double assignment of the environment #

Patch Set 3 : #

Total comments: 1

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+378 lines, -206 lines)			Patch
M	runtime/vm/bit_vector.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/bit_vector.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/bit_vector_test.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph.h	View		3 chunks	+76 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph.cc	View		8 chunks	+239 lines, -12 lines	1 comment	Download
M	runtime/vm/flow_graph_allocator.h	View		5 chunks	+17 lines, -37 lines	0 comments	Download
M	runtime/vm/flow_graph_allocator.cc	View		10 chunks	+16 lines, -102 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intermediate_language.h	View		8 chunks	+16 lines, -14 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View		4 chunks	+8 lines, -34 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

Moving review to Kevin as he reviewed original change.

7 years, 8 months ago (2013-04-12 14:48:16 UTC) #3

Florian Schneider

LGTM. https://codereview.chromium.org/14215006/diff/8001/runtime/vm/flow_graph.cc File runtime/vm/flow_graph.cc (right): https://codereview.chromium.org/14215006/diff/8001/runtime/vm/flow_graph.cc#newcode385 runtime/vm/flow_graph.cc:385: Make empty lines consistent with the StoreLocal case ...

7 years, 8 months ago (2013-04-15 10:45:09 UTC) #4

Vyacheslav Egorov (Google)

7 years, 8 months ago (2013-04-15 11:54:06 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r21439 (presubmit successful).

Expand Messages | Collapse Messages