Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 1420843004: Remove `disableNewTaskModel` failsafe. (Closed)

Created:
5 years, 1 month ago by pquitslund
Modified:
5 years, 1 month ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/analyzer_cli.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove `disableNewTaskModel` failsafe. No turning back now! :) R=scheglov@google.com Committed: https://github.com/dart-lang/analyzer_cli/commit/b4087e91c9f94adc091812794d2954305be836e9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M lib/src/driver.dart View 2 chunks +0 lines, -5 lines 0 comments Download
M lib/src/options.dart View 3 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
pquitslund
5 years, 1 month ago (2015-10-30 15:07:30 UTC) #2
scheglov
LGTM
5 years, 1 month ago (2015-10-30 15:23:37 UTC) #3
pquitslund
Committed patchset #1 (id:1) manually as b4087e91c9f94adc091812794d2954305be836e9 (presubmit successful).
5 years, 1 month ago (2015-10-30 15:29:54 UTC) #4
Brian Wilkerson
5 years, 1 month ago (2015-10-30 15:34:30 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698