Improve WebSocket interface by making it implement StreamSink.

Improve WebSocket interface by making it implement StreamSink.

This renames send to add, but also adds the addStream method, making it
possible to pause/resume the underlying Socket.

Remove http_shutdown_test from status file. Crash have not been seen for a while.

BUG=

Committed: https://code.google.com/p/dart/source/detail?r=21553

[Søren Gjesse, 2013-04-16 12:41:31]

LGTM

Remember to send out a breaking change mail.

https://codereview.chromium.org/14208007/diff/1/sdk/lib/io/io_sink.dart
File sdk/lib/io/io_sink.dart (right):

https://codereview.chromium.org/14208007/diff/1/sdk/lib/io/io_sink.dart#newco...
sdk/lib/io/io_sink.dart:55: class _StreamSinkImpl<T> implements StreamSink<T> {
Should this class be public in dart:async to enable StreamSink implementations
for users?

https://codereview.chromium.org/14208007/diff/1/sdk/lib/io/websocket.dart
File sdk/lib/io/websocket.dart (right):

https://codereview.chromium.org/14208007/diff/1/sdk/lib/io/websocket.dart#new...
sdk/lib/io/websocket.dart:134: * Closes the web socket connection.
Please add documentation on the default values. It is possible to not have a
status code and the server will see that. Reason is ignored if there is no
status code. Should we fail in that case?

https://codereview.chromium.org/14208007/diff/1/sdk/lib/io/websocket.dart#new...
sdk/lib/io/websocket.dart:142: void add(data);
We should add addStream with some dartdoc here as well. It should briefly
explain how to get flow control using a StreamController.

How about addError? How will that work?

https://codereview.chromium.org/14208007/diff/1/sdk/lib/io/websocket_impl.dart
File sdk/lib/io/websocket_impl.dart (right):

https://codereview.chromium.org/14208007/diff/1/sdk/lib/io/websocket_impl.dar...
sdk/lib/io/websocket_impl.dart:476: void sendFrame(int opcode, List<int> data,
EventSink<List<int>> sink) {
Rename to addFrame.

https://codereview.chromium.org/14208007/diff/1/sdk/lib/io/websocket_impl.dar...
sdk/lib/io/websocket_impl.dart:688: [bool this._serverSide = false]) {
Disable TCP_NODELAY here as well.

[Anders Johnsen, 2013-04-16 13:46:22]

PTAL

https://codereview.chromium.org/14208007/diff/1/sdk/lib/io/io_sink.dart
File sdk/lib/io/io_sink.dart (right):

https://codereview.chromium.org/14208007/diff/1/sdk/lib/io/io_sink.dart#newco...
sdk/lib/io/io_sink.dart:55: class _StreamSinkImpl<T> implements StreamSink<T> {
On 2013/04/16 12:41:31, Søren Gjesse wrote:
> Should this class be public in dart:async to enable StreamSink implementations
> for users?

Maybe. I'll consider moving it later on, after talking with Florian.

https://codereview.chromium.org/14208007/diff/1/sdk/lib/io/websocket.dart
File sdk/lib/io/websocket.dart (right):

https://codereview.chromium.org/14208007/diff/1/sdk/lib/io/websocket.dart#new...
sdk/lib/io/websocket.dart:134: * Closes the web socket connection.
On 2013/04/16 12:41:31, Søren Gjesse wrote:
> Please add documentation on the default values. It is possible to not have a
> status code and the server will see that. Reason is ignored if there is no
> status code. Should we fail in that case?

Done.

https://codereview.chromium.org/14208007/diff/1/sdk/lib/io/websocket.dart#new...
sdk/lib/io/websocket.dart:142: void add(data);
On 2013/04/16 12:41:31, Søren Gjesse wrote:
> We should add addStream with some dartdoc here as well. It should briefly
> explain how to get flow control using a StreamController.
> 
> How about addError? How will that work?

addError will more or less just close the connection. No need to extra
information about that (same as on http/socket).

https://codereview.chromium.org/14208007/diff/1/sdk/lib/io/websocket_impl.dart
File sdk/lib/io/websocket_impl.dart (right):

https://codereview.chromium.org/14208007/diff/1/sdk/lib/io/websocket_impl.dar...
sdk/lib/io/websocket_impl.dart:476: void sendFrame(int opcode, List<int> data,
EventSink<List<int>> sink) {
On 2013/04/16 12:41:31, Søren Gjesse wrote:
> Rename to addFrame.

Done.

[Søren Gjesse, 2013-04-16 13:47:48]

lgtm

[Anders Johnsen, 2013-04-16 15:08:35]

Committed patchset #3 manually as r21553 (presubmit successful).