Issue 14205023: Fully implement integer modulo in intrinsifier, fall-through only for throwing exceptions. Also int…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14205023: Fully implement integer modulo in intrinsifier, fall-through only for throwing exceptions. Also int… (Closed)

Created:
7 years, 8 months ago by srdjan

Modified:
7 years, 8 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fully implement integer modulo in intrinsifier, fall-through only for throwing exceptions. Also intrinsified remainder operation. TODO: generate inline code for both % and remainder. Committed: https://code.google.com/p/dart/source/detail?r=21754

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+187 lines, -37 lines)			Patch
M	runtime/vm/intrinsifier.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/intrinsifier_arm.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/intrinsifier_ia32.cc	View	1	1 chunk	+88 lines, -16 lines	0 comments	Download
M	runtime/vm/intrinsifier_mips.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/intrinsifier_x64.cc	View	1	5 chunks	+88 lines, -21 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

7 years, 8 months ago (2013-04-19 16:56:43 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r21754 (presubmit successful).

Expand Messages | Collapse Messages