Remove typeddata transferable constructors

Remove typeddata transferable constructors

These constructors are not in the public/shared typeddata.dart.  Tests
updated accordingly.

Committed: https://code.google.com/p/dart/source/detail?r=21576

[vsm, 2013-04-12 22:54:43]

https://chromiumcodereview.appspot.com/14205004/diff/1/runtime/lib/typeddata....
File runtime/lib/typeddata.dart (right):

https://chromiumcodereview.appspot.com/14205004/diff/1/runtime/lib/typeddata....
runtime/lib/typeddata.dart:45: static _ExternalUint8Array _newTransferable(int
length) {
Are these still needed?  I left them in as they are not public and could
presumably be called directly by the embedder.

[siva, 2013-04-13 08:00:59]

Anton had initially mentioned that he may need this functionality of being able
to create external typed data from Dart code and that is why I retained most of
the stuff and did not delete them. Is this not a requirement anymore for the
dart:html library.

[siva, 2013-04-15 18:09:04]

lgtm

https://chromiumcodereview.appspot.com/14205004/diff/1/runtime/lib/typeddata....
File runtime/lib/typeddata.dart (right):

https://chromiumcodereview.appspot.com/14205004/diff/1/runtime/lib/typeddata....
runtime/lib/typeddata.dart:45: static _ExternalUint8Array _newTransferable(int
length) {
I don't think these are called from the embedder, I would remove these too.

On 2013/04/12 22:54:43, vsm wrote:
> Are these still needed?  I left them in as they are not public and could
> presumably be called directly by the embedder.

https://chromiumcodereview.appspot.com/14205004/diff/1/tests/standalone/typed...
File tests/standalone/typed_data_test.dart (left):

https://chromiumcodereview.appspot.com/14205004/diff/1/tests/standalone/typed...
tests/standalone/typed_data_test.dart:68: }
I am wondering if we should move this test to
dart_api_impl_test.cc by creating an external uint8clampedArray using the API.

Something similar to
TEST_CASE(ExternalUint8ClampedArrayAccess)

[vsm, 2013-04-16 20:55:18]

Committed patchset #2 manually as r21576 (presubmit successful).

[vsm, 2013-04-16 21:01:57]

https://chromiumcodereview.appspot.com/14205004/diff/1/runtime/lib/typeddata....
File runtime/lib/typeddata.dart (right):

https://chromiumcodereview.appspot.com/14205004/diff/1/runtime/lib/typeddata....
runtime/lib/typeddata.dart:45: static _ExternalUint8Array _newTransferable(int
length) {
On 2013/04/15 18:09:05, siva wrote:
> I don't think these are called from the embedder, I would remove these too.
> 
> On 2013/04/12 22:54:43, vsm wrote:
> > Are these still needed?  I left them in as they are not public and could
> > presumably be called directly by the embedder.
> 

Done.

https://chromiumcodereview.appspot.com/14205004/diff/1/tests/standalone/typed...
File tests/standalone/typed_data_test.dart (left):

https://chromiumcodereview.appspot.com/14205004/diff/1/tests/standalone/typed...
tests/standalone/typed_data_test.dart:68: }
This sounds like a good idea.  Can someone on the VM team followup on this?

On 2013/04/15 18:09:05, siva wrote:
> I am wondering if we should move this test to
> dart_api_impl_test.cc by creating an external uint8clampedArray using the API.
> 
> Something similar to
> TEST_CASE(ExternalUint8ClampedArrayAccess)