Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1420303010: add 'imports' field for OutputUnitInfo (Closed)

Created:
5 years, 1 month ago by Harry Terkelsen
Modified:
5 years, 1 month ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dart2js_info.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M CHANGELOG.md View 1 chunk +3 lines, -0 lines 0 comments Download
M lib/info.dart View 1 chunk +4 lines, -0 lines 2 comments Download
M lib/json_info_codec.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Harry Terkelsen
5 years, 1 month ago (2015-11-04 02:07:30 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/1420303010/diff/1/lib/info.dart File lib/info.dart (right): https://codereview.chromium.org/1420303010/diff/1/lib/info.dart#newcode206 lib/info.dart:206: List<String> imports = <String>[]; Oh funny, my initial ...
5 years, 1 month ago (2015-11-04 03:33:16 UTC) #3
Harry Terkelsen
https://codereview.chromium.org/1420303010/diff/1/lib/info.dart File lib/info.dart (right): https://codereview.chromium.org/1420303010/diff/1/lib/info.dart#newcode206 lib/info.dart:206: List<String> imports = <String>[]; On 2015/11/04 03:33:16, Siggi Cherem ...
5 years, 1 month ago (2015-11-12 19:21:01 UTC) #4
Harry Terkelsen
5 years, 1 month ago (2015-11-12 19:21:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0a221eaf16aec3879c45719de656680ccb80d8a1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698