Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 14201004: Debugger wire protocol changes (Closed)

Created:
7 years, 8 months ago by hausner
Modified:
7 years, 8 months ago
Reviewers:
devoncarew
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Debugger wire protocol changes - Add 'number' value type for transmitting values of type num - Eliminate 'integer' value types (subsumed in number values) - Eliminate url and line number fields in breakpointResolved events Committed: https://code.google.com/p/dart/source/detail?r=21745

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M runtime/bin/dbg_message.cc View 3 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hausner
I think the Editor is ready for all of these changes and cleanups, right?
7 years, 8 months ago (2013-04-18 18:12:16 UTC) #1
devoncarew
On 2013/04/18 18:12:16, hausner wrote: > I think the Editor is ready for all of ...
7 years, 8 months ago (2013-04-19 14:10:47 UTC) #2
devoncarew
lgtm
7 years, 8 months ago (2013-04-19 14:11:43 UTC) #3
hausner
Committed patchset #1 manually as r21745 (presubmit successful).
7 years, 8 months ago (2013-04-19 15:20:48 UTC) #4
hausner
7 years, 8 months ago (2013-04-19 15:27:15 UTC) #5
Message was sent while issue was closed.
Thank you!

Powered by Google App Engine
This is Rietveld 408576698