Issue 14196003: Change StreamController constructor.

Issue 14196003: Change StreamController constructor. (Closed)

Created:
7 years, 8 months ago by floitsch

Modified:
7 years, 8 months ago

Reviewers:
Lasse Reichstein Nielsen, Anders Johnsen

CC:
reviews_dartlang.org, Anders Johnsen, Jennifer Messerly, Siggi Cherem (dart-lang)

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Change StreamController constructor. Committed: https://code.google.com/p/dart/source/detail?r=21472

Patch Set 3 : Another missing ','. #

Patch Set 4 : Fix some bugs. #

Total comments: 6

Patch Set 5 : Address comments and rebase. #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+168 lines, -167 lines)			Patch
M	runtime/bin/socket_patch.dart	View	1 2 3 4	3 chunks	+12 lines, -6 lines	0 comments	Download
M	sdk/lib/async/stream.dart	View	1 2 3 4	2 chunks	+28 lines, -38 lines	0 comments	Download
M	sdk/lib/async/stream_controller.dart	View	1 2 3 4	3 chunks	+69 lines, -55 lines	0 comments	Download
M	sdk/lib/io/file_impl.dart	View	1 2 3 4	2 chunks	+7 lines, -19 lines	0 comments	Download
M	sdk/lib/io/http_impl.dart	View	1 2 3 4	1 chunk	+4 lines, -2 lines	0 comments	Download
M	sdk/lib/io/http_parser.dart	View	1 2 3 4	4 chunks	+12 lines, -22 lines	0 comments	Download
M	sdk/lib/io/secure_server_socket.dart	View	1 2 3 4	1 chunk	+4 lines, -2 lines	0 comments	Download
M	sdk/lib/io/secure_socket.dart	View	1 2 3 4	1 chunk	+4 lines, -2 lines	0 comments	Download
M	tests/lib/async/slow_consumer2_test.dart	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	tests/lib/async/slow_consumer_test.dart	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	tests/lib/async/stream_state_helper.dart	View	1 2 3 4	1 chunk	+8 lines, -4 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Geolocation.darttemplate	View		1 chunk	+14 lines, -15 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

floitsch

Imho this looks much nicer and makes the code more readable.

7 years, 8 months ago (2013-04-14 12:55:36 UTC) #1

Lasse Reichstein Nielsen

Quick LGTM. https://codereview.chromium.org/14196003/diff/6001/sdk/lib/async/stream_controller.dart File sdk/lib/async/stream_controller.dart (right): https://codereview.chromium.org/14196003/diff/6001/sdk/lib/async/stream_controller.dart#newcode65 sdk/lib/async/stream_controller.dart:65: StreamController.broadcast({void onListen(), Wasn't this constructor deprecated? And ...

7 years, 8 months ago (2013-04-15 10:07:43 UTC) #3

floitsch

https://codereview.chromium.org/14196003/diff/6001/sdk/lib/async/stream_controller.dart File sdk/lib/async/stream_controller.dart (right): https://codereview.chromium.org/14196003/diff/6001/sdk/lib/async/stream_controller.dart#newcode65 sdk/lib/async/stream_controller.dart:65: StreamController.broadcast({void onListen(), On 2013/04/15 10:07:43, Lasse Reichstein Nielsen wrote: ...

7 years, 8 months ago (2013-04-15 16:33:43 UTC) #4

floitsch

7 years, 8 months ago (2013-04-15 16:34:44 UTC) #5

Message was sent while issue was closed.

Committed patchset #5 manually as r21472 (presubmit successful).

Expand Messages | Collapse Messages