Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 1419493002: Make MediaType case-insensitive, following the spec. (Closed)

Created:
5 years, 2 months ago by nweiz
Modified:
5 years, 2 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/http_parser@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -5 lines) Patch
M CHANGELOG.md View 1 chunk +6 lines, -0 lines 0 comments Download
M lib/src/media_type.dart View 3 chunks +11 lines, -4 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/media_type_test.dart View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
5 years, 2 months ago (2015-10-19 20:28:07 UTC) #1
kevmoo
lgtm – but tests?
5 years, 2 months ago (2015-10-19 21:31:40 UTC) #2
nweiz
On 2015/10/19 21:31:40, kevmoo wrote: > lgtm – but tests? Done.
5 years, 2 months ago (2015-10-19 21:42:08 UTC) #3
nweiz
5 years, 2 months ago (2015-10-19 21:42:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0aea125960e04fa2e13260250ee78dc4dbb1df95 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698