Removed product_dir override in runtime/dart-runtime.gyp

Removed product_dir override in runtime/dart-runtime.gyp

Committed: https://code.google.com/p/dart/source/detail?r=21793

[kustermann, 2013-04-22 09:05:29]

I hope this will fix our dartium issues.

[ricow1, 2013-04-22 09:06:05]

LGTM, it will :-)

[kustermann, 2013-04-22 09:06:28]

Committed patchset #1 manually as r21793 (presubmit successful).

[ricow1, 2013-04-22 09:07:49]

On 2013/04/22 09:06:05, ricow1 wrote:
> LGTM, it will :-)

Zachary: This was causing dartium mac bots to fail compiling, see e.g.:
http://build.chromium.org/p/client.dart/builders/dartium-mac-full/builds/4155...

Is this needed for cross-compilation to work?

[zra, 2013-04-22 16:33:12]

On 2013/04/22 09:07:49, ricow1 wrote:
> On 2013/04/22 09:06:05, ricow1 wrote:
> > LGTM, it will :-)
> 
> Zachary: This was causing dartium mac bots to fail compiling, see e.g.:
>
http://build.chromium.org/p/client.dart/builders/dartium-mac-full/builds/4155...
> 
> Is this needed for cross-compilation to work?

Yes, it is needed for cross-compilation. I'll look into what I have to do on Mac
to get the file into the right place.

[kustermann, 2013-04-22 17:01:25]

On 2013/04/22 16:33:12, zra wrote:
> On 2013/04/22 09:07:49, ricow1 wrote:
> > On 2013/04/22 09:06:05, ricow1 wrote:
> > > LGTM, it will :-)
> > 
> > Zachary: This was causing dartium mac bots to fail compiling, see e.g.:
> >
>
http://build.chromium.org/p/client.dart/builders/dartium-mac-full/builds/4155...
> > 
> > Is this needed for cross-compilation to work?
> 
> Yes, it is needed for cross-compilation. I'll look into what I have to do on
Mac
> to get the file into the right place.

We looked into this a bit this morning. Here is what's happening:
Chrome/Dartium has a special 'postbuilds' action on mac (see
'src/build/common.gypi)
which calls 'build/mac/change_mach_o_flags_from_xcode.sh'. This shell script
uses the environment variables BUILT_PRODUCTS_DIR/EXECUTABLE_PATH to find the
executable and then calls 'build/mac/change_mach_o_flags.py' (I think this one
enables ALSR and marks the heap section as non-exec).

The shell script then generates the wrong path (the libdart_dependency_helper
file is not where it expects it to be) -- so it fails.