Issue 14192032: Implement missing features to run Hello world! in checked mode on simulated ARM.

Issue 14192032: Implement missing features to run Hello world! in checked mode on simulated ARM. (Closed)

Created:
7 years, 8 months ago by regis

Modified:
7 years, 8 months ago

Reviewers:
zra, srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Implement missing features to run Hello world! in checked mode on simulated ARM. Committed: https://code.google.com/p/dart/source/detail?r=21780

Patch Set 2 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+213 lines, -82 lines)			Patch
M	runtime/vm/assembler_arm.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/assembler_arm.cc	View	1	2 chunks	+13 lines, -11 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm.cc	View	1	5 chunks	+80 lines, -7 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1	11 chunks	+33 lines, -56 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View	1	1 chunk	+82 lines, -1 line	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

srdjan

DBC https://codereview.chromium.org/14192032/diff/1/runtime/vm/flow_graph_compiler_arm.cc File runtime/vm/flow_graph_compiler_arm.cc (right): https://codereview.chromium.org/14192032/diff/1/runtime/vm/flow_graph_compiler_arm.cc#newcode288 runtime/vm/flow_graph_compiler_arm.cc:288: // Generates inlined check if 'type' is a ...

7 years, 8 months ago (2013-04-19 22:56:40 UTC) #2

regis

Thanks! https://codereview.chromium.org/14192032/diff/1/runtime/vm/flow_graph_compiler_arm.cc File runtime/vm/flow_graph_compiler_arm.cc (right): https://codereview.chromium.org/14192032/diff/1/runtime/vm/flow_graph_compiler_arm.cc#newcode288 runtime/vm/flow_graph_compiler_arm.cc:288: // Generates inlined check if 'type' is a ...

7 years, 8 months ago (2013-04-19 23:19:19 UTC) #4

regis

7 years, 8 months ago (2013-04-19 23:21:19 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r21780 (presubmit successful).

Expand Messages | Collapse Messages