Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 14191002: Added dart2js-generated vmstats.dart, to support non-Dartium browsers. (Closed)

Created:
7 years, 8 months ago by Tom Ball
Modified:
7 years, 8 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Added dart2js-generated vmstats.dart, to support non-Dartium browsers. Committed: https://code.google.com/p/dart/source/detail?r=21631

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8861 lines, -0 lines) Patch
A runtime/bin/vmstats/README View 1 1 chunk +13 lines, -0 lines 0 comments Download
A runtime/bin/vmstats/vmstats.dart.js View 1 1 chunk +8848 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Tom Ball
I generated vmstats.dart.js by hand, so let me know if it would be better to ...
7 years, 8 months ago (2013-04-11 20:26:00 UTC) #1
Tom Ball
I won't submit this until 13939003 is submitted, so it has the latest vmstats.dart changes.
7 years, 8 months ago (2013-04-11 23:42:06 UTC) #2
Ivan Posva
LGTM, but please add a README on how to regenerate this in the future. Thanks, ...
7 years, 8 months ago (2013-04-12 14:39:12 UTC) #3
Tom Ball
On 2013/04/12 14:39:12, Ivan Posva wrote: > LGTM, but please add a README on how ...
7 years, 8 months ago (2013-04-17 16:30:12 UTC) #4
Tom Ball
7 years, 8 months ago (2013-04-17 16:30:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r21631 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698