Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 14189023: Fix clang unused-private-field error. (Closed)

Created:
7 years, 8 months ago by tfarina
Modified:
7 years, 8 months ago
CC:
reviews_dartlang.org, Kasper Lund, Søren Thygesen Gjesse, scheglov
Visibility:
Public.

Description

Fix clang unused-private-field error. ../../runtime/vm/dart_api_state.h:736:18: error: private field 'key_' is not used [-Werror,-Wunused-private-field] ThreadLocalKey key_; ^ R=scheglov@google.com TEST=ninja -C out/Debug Signed-off-by: Thiago Farina <tfarina@chromium.org>; Committed: https://code.google.com/p/dart/source/detail?r=21778

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M runtime/vm/dart_api_state.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
Hi, could you review this to me? Note that I don't have dart commit access. ...
7 years, 8 months ago (2013-04-19 13:24:03 UTC) #1
tfarina
Egorov, looks like someone assigned you as a reviewer instead of scheglov@google.com. May be could ...
7 years, 8 months ago (2013-04-19 22:13:28 UTC) #2
Vyacheslav Egorov (Google)
LGTM
7 years, 8 months ago (2013-04-19 22:31:47 UTC) #3
Vyacheslav Egorov (Google)
7 years, 8 months ago (2013-04-19 22:42:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r21778 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698