Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Issue 14189020: Try to fix flakiness of test standalone/io/raw_secure_server_socket_test (Closed)

Created:
7 years, 8 months ago by Søren Gjesse
Modified:
7 years, 8 months ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Try to fix flakiness of test standalone/io/raw_secure_server_socket_test The test tests/standalone/io/raw_secure_server_socket_test.dart could complete the same future twice. This should fix that. R=ager@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=21739

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M sdk/lib/io/secure_socket.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/standalone/io/raw_secure_server_socket_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
7 years, 8 months ago (2013-04-19 10:14:56 UTC) #1
Mads Ager (google)
LGTM
7 years, 8 months ago (2013-04-19 12:07:32 UTC) #2
Søren Gjesse
7 years, 8 months ago (2013-04-19 12:28:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21739 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698