Issue 14188003: - Avoid failing on the buildbot on Mac OS X 10.6.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14188003: - Avoid failing on the buildbot on Mac OS X 10.6. (Closed)

Created:
7 years, 8 months ago by Ivan Posva

Modified:
7 years, 8 months ago

Reviewers:
ricow1, ahe

CC:
reviews_dartlang.org, ahe

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Avoid failing on the buildbot on Mac OS X 10.6. Committed: https://code.google.com/p/dart/source/detail?r=21306

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	tools/build.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ahe

This sounds urgent to me, so LGTM. Could you point me to an example where ...

7 years, 8 months ago (2013-04-11 20:13:49 UTC) #3

Ivan Posva

Committed patchset #1 manually as r21306 (presubmit successful).

7 years, 8 months ago (2013-04-11 20:14:26 UTC) #4

Ivan Posva

7 years, 8 months ago (2013-04-11 20:42:38 UTC) #5

Message was sent while issue was closed.

On 2013/04/11 20:13:49, ahe wrote:
> This sounds urgent to me, so LGTM.
> 
> Could you point me to an example where this breaks?

This breaks on the Mac OS X 10.6 buildbot Rico has been setting up. I am sure he
can give you access once I am done with it. Here is the error I had been seeing:
bash$ ../tools/build.py 
xcodebuild -project dart-runtime.xcodeproj -target All -configuration DebugIA32
SYMROOT=/private/tmp/dart-standalone/dart/runtime/xcodebuild
Traceback (most recent call last):
 File "../tools/build.py", line 435, in <module>
   sys.exit(Main())
 File "../tools/build.py", line 423, in Main
   FilterEmptyXcodebuildSections(process)
 File "../tools/build.py", line 272, in FilterEmptyXcodebuildSections
   clr_eol = subprocess.check_output(['tput', '-T' + term, 'el'],
AttributeError: 'module' object has no attribute 'check_output'

-Ivan

Expand Messages | Collapse Messages