Issue 141823002: Use Object as supertype in face of invalid supertypes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 141823002: Use Object as supertype in face of invalid supertypes. (Closed)

Created:
6 years, 11 months ago by Johnni Winther

Modified:
6 years, 10 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use Object as supertype in face of invalid supertypes. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=32113

Patch Set 3 : Updated cf. comment. #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -7 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View	1 2	3 chunks	+6 lines, -4 lines	0 comments	Download
	M	tests/language/language_dart2js.status	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

karlklose

LGTM. https://codereview.chromium.org/141823002/diff/1/sdk/lib/_internal/compiler/implementation/resolution/members.dart File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right): https://codereview.chromium.org/141823002/diff/1/sdk/lib/_internal/compiler/implementation/resolution/members.dart#newcode4114 sdk/lib/_internal/compiler/implementation/resolution/members.dart:4114: return compiler.objectClass.computeType(compiler); Extract a getter for this type. ...

6 years, 10 months ago (2014-01-28 13:30:02 UTC) #2

Johnni Winther

Committed patchset #3 manually as r32113 (presubmit successful).

6 years, 10 months ago (2014-01-29 09:59:11 UTC) #3

Johnni Winther

6 years, 10 months ago (2014-01-29 10:26:08 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/141823002/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/141823002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:4114: return
compiler.objectClass.computeType(compiler);
On 2014/01/28 13:30:03, karlklose wrote:
> Extract a getter for this type. Also it should be objectClass.rawType.

Done.

Expand Messages | Collapse Messages

Issue 141823002: Use Object as supertype in face of invalid supertypes. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Updated cf. comment. #

Messages