Issue 141803019: Enter and Exit scope when calling into the native library tag handler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 141803019: Enter and Exit scope when calling into the native library tag handler (Closed)

Created:
6 years, 10 months ago by siva

Modified:
6 years, 10 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Enter and Exit scope when calling into the native library tag handler instead of relying on an outer enclosing scope. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=32346

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -6 lines)			Patch
	M	runtime/vm/bootstrap.cc	View	1	2 chunks	+1 line, -6 lines	0 comments	Download
	M	runtime/vm/parser.cc	View		2 chunks	+14 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

hausner

LGTM w/comment. https://codereview.chromium.org/141803019/diff/40001/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/141803019/diff/40001/runtime/vm/parser.cc#newcode4888 runtime/vm/parser.cc:4888: DartApiScope api_scope(isolate()); If this is the only ...

6 years, 10 months ago (2014-02-05 22:22:56 UTC) #2

siva

https://codereview.chromium.org/141803019/diff/40001/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/141803019/diff/40001/runtime/vm/parser.cc#newcode4888 runtime/vm/parser.cc:4888: DartApiScope api_scope(isolate()); The reason I made it a class ...

6 years, 10 months ago (2014-02-05 23:10:54 UTC) #3

siva

6 years, 10 months ago (2014-02-05 23:42:08 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r32346 (presubmit successful).

Expand Messages | Collapse Messages