Added support for solo groups, multiple solo tests, and

Added support for solo groups, multiple solo tests, and
skip groups/tests.

Committed: https://code.google.com/p/dart/source/detail?r=22075

[kevmoo-old, 2013-04-25 21:56:34]

DBR

https://codereview.chromium.org/14180015/diff/1/pkg/unittest/lib/unittest.dart
File pkg/unittest/lib/unittest.dart (right):

https://codereview.chromium.org/14180015/diff/1/pkg/unittest/lib/unittest.dar...
pkg/unittest/lib/unittest.dart:367: test(spec, body);
DBR: try...finally?

https://codereview.chromium.org/14180015/diff/1/pkg/unittest/lib/unittest.dar...
pkg/unittest/lib/unittest.dart:624: group(description, body);
DBR: try...finally?

[gram, 2013-04-25 22:01:16]

PTAL

https://codereview.chromium.org/14180015/diff/1/pkg/unittest/lib/unittest.dart
File pkg/unittest/lib/unittest.dart (right):

https://codereview.chromium.org/14180015/diff/1/pkg/unittest/lib/unittest.dar...
pkg/unittest/lib/unittest.dart:367: test(spec, body);
On 2013/04/25 21:56:34, kevmoo wrote:
> DBR: try...finally?

Done.

https://codereview.chromium.org/14180015/diff/1/pkg/unittest/lib/unittest.dar...
pkg/unittest/lib/unittest.dart:624: group(description, body);
On 2013/04/25 21:56:34, kevmoo wrote:
> DBR: try...finally?

Done.

[Siggi Cherem (dart-lang), 2013-04-26 03:38:23]

nice, one small suggestion, but otherwise lgtm

https://codereview.chromium.org/14180015/diff/5001/pkg/unittest/lib/unittest....
File pkg/unittest/lib/unittest.dart (right):

https://codereview.chromium.org/14180015/diff/5001/pkg/unittest/lib/unittest....
pkg/unittest/lib/unittest.dart:217: * The set of tests to run can be restricted
by using soloTest and soloGroup.
soloTest => [solo_test]
soloGroup => [solo_group]

https://codereview.chromium.org/14180015/diff/5001/pkg/unittest/lib/unittest....
pkg/unittest/lib/unittest.dart:221: int _solo_level = -1;
nit: _solo_level => _soloLevel;

https://codereview.chromium.org/14180015/diff/5001/pkg/unittest/lib/unittest....
pkg/unittest/lib/unittest.dart:333: if (_solo_level != 0) {
I wonder if we can make this logic a bit more readable by splitting the meaning
of _solo_level in two. Basically using the '-1' value as a separate variable:

bool _soloTestsSeen = false;
bool _soloNestingLevel = 0;

Then here you would check:
if (!_soloTestSeen || _soloNestingLevel > 1) {
   ...
}

And below you could do:
solo_test( ...) {
  if (!_soloTestSeen) {
    _soloTestSeen = true;
    _testCases.clear();
  }
  ...

https://codereview.chromium.org/14180015/diff/5001/pkg/unittest/lib/unittest....
pkg/unittest/lib/unittest.dart:351: * [skip_test], or whether they are in a
nested [group] vs [solo_group]. Put
skip_test => solo_test (skip test will always be skipped)

https://codereview.chromium.org/14180015/diff/5001/pkg/unittest/lib/unittest....
pkg/unittest/lib/unittest.dart:835: for (var i = 0; i < testCases.length; i++) {
now that collections have improved, you can simply do:

void setSoloTest(int id) =>
  _testCases.retainWhere((t) => t.id == id);

[gram, 2013-04-26 17:35:01]

Committed patchset #3 manually as r22075 (presubmit successful).

[gram, 2013-04-26 17:35:44]

https://codereview.chromium.org/14180015/diff/5001/pkg/unittest/lib/unittest....
File pkg/unittest/lib/unittest.dart (right):

https://codereview.chromium.org/14180015/diff/5001/pkg/unittest/lib/unittest....
pkg/unittest/lib/unittest.dart:217: * The set of tests to run can be restricted
by using soloTest and soloGroup.
On 2013/04/26 03:38:23, Siggi Cherem (dart-lang) wrote:
> soloTest => [solo_test]
> soloGroup => [solo_group]

Done.

https://codereview.chromium.org/14180015/diff/5001/pkg/unittest/lib/unittest....
pkg/unittest/lib/unittest.dart:221: int _solo_level = -1;
On 2013/04/26 03:38:23, Siggi Cherem (dart-lang) wrote:
> nit: _solo_level => _soloLevel;

Done.

https://codereview.chromium.org/14180015/diff/5001/pkg/unittest/lib/unittest....
pkg/unittest/lib/unittest.dart:333: if (_solo_level != 0) {
On 2013/04/26 03:38:23, Siggi Cherem (dart-lang) wrote:
> I wonder if we can make this logic a bit more readable by splitting the
meaning
> of _solo_level in two. Basically using the '-1' value as a separate variable:
> 
> bool _soloTestsSeen = false;
> bool _soloNestingLevel = 0;
> 
> Then here you would check:
> if (!_soloTestSeen || _soloNestingLevel > 1) {
>    ...
> }
> 
> And below you could do:
> solo_test( ...) {
>   if (!_soloTestSeen) {
>     _soloTestSeen = true;
>     _testCases.clear();
>   }
>   ...

Done.

https://codereview.chromium.org/14180015/diff/5001/pkg/unittest/lib/unittest....
pkg/unittest/lib/unittest.dart:351: * [skip_test], or whether they are in a
nested [group] vs [solo_group]. Put
On 2013/04/26 03:38:23, Siggi Cherem (dart-lang) wrote:
> skip_test => solo_test (skip test will always be skipped)

Done.

https://codereview.chromium.org/14180015/diff/5001/pkg/unittest/lib/unittest....
pkg/unittest/lib/unittest.dart:835: for (var i = 0; i < testCases.length; i++) {
On 2013/04/26 03:38:23, Siggi Cherem (dart-lang) wrote:
> now that collections have improved, you can simply do:
> 
> void setSoloTest(int id) =>
>   _testCases.retainWhere((t) => t.id == id);

Done.

[Siggi Cherem (dart-lang), 2013-04-26 18:53:47]

https://codereview.chromium.org/14180015/diff/10001/pkg/unittest/lib/unittest...
File pkg/unittest/lib/unittest.dart (right):

https://codereview.chromium.org/14180015/diff/10001/pkg/unittest/lib/unittest...
pkg/unittest/lib/unittest.dart:337: body);
nit: fix indentation (should just be +4)

given that this is already wrapping, seems like we don't win much by adding the
variable declaration.