Issue 1417993002: Fix a bug in pubspec parsing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1417993002: Fix a bug in pubspec parsing. (Closed)

Created:
5 years, 2 months ago by nweiz

Modified:
5 years, 2 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/pub.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix a bug in pubspec parsing. We didn't properly check for no sources in a dependency, which caused a crash for some invalid pubspecs. Closes #1348 R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/597233aacf56bdcf445b2493884ece4d95fcf79a

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	lib/src/pubspec.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	test/pubspec_test.dart	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

nweiz

5 years, 2 months ago (2015-10-21 21:06:24 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
597233aacf56bdcf445b2493884ece4d95fcf79a (presubmit successful).