Issue 1417943004: Use shelf's Server API in browser/server.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1417943004: Use shelf's Server API in browser/server. (Closed)

Created:
5 years, 1 month ago by nweiz

Modified:
5 years, 1 month ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Use shelf's Server API in browser/server. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/38a9f743881a3bec48e5984596fdaea4b1215182

Patch Set 2 : Code review changes #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -33 lines)			Patch
M	lib/src/runner/browser/server.dart	View		4 chunks	+8 lines, -14 lines	0 comments	Download
M	lib/src/util/io.dart	View		1 chunk	+0 lines, -17 lines	0 comments	Download
M	pubspec.yaml	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kevmoo

lgtm https://codereview.chromium.org/1417943004/diff/1/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/1417943004/diff/1/pubspec.yaml#newcode2 pubspec.yaml:2: version: 0.12.5+1 version tweak for the refactor?

5 years, 1 month ago (2015-10-27 02:34:47 UTC) #2

nweiz

Committed patchset #2 (id:20001) manually as 38a9f743881a3bec48e5984596fdaea4b1215182 (presubmit successful).

5 years, 1 month ago (2015-10-27 20:34:40 UTC) #4

nweiz

5 years, 1 month ago (2015-10-27 20:35:11 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/1417943004/diff/1/pubspec.yaml
File pubspec.yaml (right):

https://codereview.chromium.org/1417943004/diff/1/pubspec.yaml#newcode2
pubspec.yaml:2: version: 0.12.5+1
On 2015/10/27 02:34:47, kevmoo wrote:
> version tweak for the refactor?

Done.

Expand Messages | Collapse Messages

Issue 1417943004: Use shelf's Server API in browser/server. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Code review changes #

Messages