Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 1417523005: Include the request context for shelf_io errors. (Closed)

Created:
5 years, 1 month ago by nweiz
Modified:
5 years, 1 month ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/shelf@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Include the request context for shelf_io errors. Closes #51 R=kevmoo@google.com Committed: https://github.com/dart-lang/shelf/commit/d37bee7fb8f9af23263a7a07fd65ae74273c1519

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -38 lines) Patch
M CHANGELOG.md View 1 chunk +5 lines, -0 lines 0 comments Download
M lib/shelf_io.dart View 2 chunks +54 lines, -37 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
5 years, 1 month ago (2015-10-28 22:09:36 UTC) #1
kevmoo
lgtm – although I'd love to see a test or 2
5 years, 1 month ago (2015-10-28 23:10:23 UTC) #2
nweiz
On 2015/10/28 23:10:23, kevmoo wrote: > lgtm – although I'd love to see a test or ...
5 years, 1 month ago (2015-10-28 23:23:34 UTC) #3
nweiz
5 years, 1 month ago (2015-10-28 23:24:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d37bee7fb8f9af23263a7a07fd65ae74273c1519 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698