Add setAll, insertAll, replaceRange and fillRange.

Add setAll, insertAll, replaceRange and fillRange.

BUG=

Committed: https://code.google.com/p/dart/source/detail?r=21471

[blois, 2013-04-12 23:03:10]

DOM changes lgtm

[Lasse Reichstein Nielsen, 2013-04-15 12:03:07]

lgtm

https://chromiumcodereview.appspot.com/14175013/diff/1/sdk/lib/core/list.dart
File sdk/lib/core/list.dart (right):

https://chromiumcodereview.appspot.com/14175013/diff/1/sdk/lib/core/list.dart...
sdk/lib/core/list.dart:211: * It is an error if the [iterable] is longer than
[length] - [index].
How about not making it an error if the iterable is longer, and just truncate.

The behavior is useful in any case, and I don't want users catching the error to
get the useful functionality.

Perhaps you could return a boolean that is true if the iterable was longer
(i.e., if it got truncated by writing).
It's probably not a good idea (boolean returns in collections tend to mean "did
the collection change").

[Lasse Reichstein Nielsen, 2013-04-15 12:11:31]

https://chromiumcodereview.appspot.com/14175013/diff/1/runtime/lib/growable_a...
File runtime/lib/growable_array.dart (right):

https://chromiumcodereview.appspot.com/14175013/diff/1/runtime/lib/growable_a...
runtime/lib/growable_array.dart:74: setRange(index, index + iterable.length,
iterable);
Notice how the other parameter structure for setRange would have allowed you to
omit the second argument entirely :P

[floitsch, 2013-04-15 16:22:47]

https://codereview.chromium.org/14175013/diff/1/sdk/lib/collection/list.dart
File sdk/lib/collection/list.dart (right):

https://codereview.chromium.org/14175013/diff/1/sdk/lib/collection/list.dart#...
sdk/lib/collection/list.dart:177: Iterable expand(Iterable f(E element)) =>
Extracted into a separate CL.
I need to commit before I can merge and remove it from this CL.

https://codereview.chromium.org/14175013/diff/1/sdk/lib/collection/list.dart#...
sdk/lib/collection/list.dart:420: void insert(int index, E element) {
Extracted into a separate CL.
I need to commit before I can merge and remove it from this CL.

https://codereview.chromium.org/14175013/diff/1/sdk/lib/collection/list.dart#...
sdk/lib/collection/list.dart:437: E removeAt(int index) {
Extracted into a separate CL.
I need to commit before I can merge and remove it from this CL.

https://codereview.chromium.org/14175013/diff/1/sdk/lib/core/list.dart
File sdk/lib/core/list.dart (right):

https://codereview.chromium.org/14175013/diff/1/sdk/lib/core/list.dart#newcod...
sdk/lib/core/list.dart:211: * It is an error if the [iterable] is longer than
[length] - [index].
On 2013/04/15 12:03:08, Lasse Reichstein Nielsen wrote:
> How about not making it an error if the iterable is longer, and just truncate.
> 
> The behavior is useful in any case, and I don't want users catching the error
to
> get the useful functionality.
> 
> Perhaps you could return a boolean that is true if the iterable was longer
> (i.e., if it got truncated by writing).
> It's probably not a good idea (boolean returns in collections tend to mean
"did
> the collection change").

Both are reasonable. I prefer the error since that gives you an error when you
write list.setAll(5, otherList.getRange(4, 7)).

[floitsch, 2013-04-15 16:25:50]

Committed patchset #1 manually as r21471 (presubmit successful).