Issue 141733009: Fix crash in VM when patching static calls. When the target code is optimized, it is possible that …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 141733009: Fix crash in VM when patching static calls. When the target code is optimized, it is possible that … (Closed)

Created:
6 years, 10 months ago by srdjan

Modified:
6 years, 10 months ago

Reviewers:
zra

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Florian Schneider

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix crash in VM when patching static calls. When the target code is optimized, it is possible that the target function has its code disconnected due to its optimized code being deoptimized and its unoptimized code not being used. In such case recompile the target. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=32337

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
	M	runtime/vm/code_generator.cc	View		1 chunk	+10 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

6 years, 10 months ago (2014-02-05 21:14:04 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r32337 (presubmit successful).

Expand Messages | Collapse Messages