Issue 14172013: Remove second generic argument of StreamConsumer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14172013: Remove second generic argument of StreamConsumer. (Closed)

Created:
7 years, 8 months ago by floitsch

Modified:
7 years, 8 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org, Lasse Reichstein Nielsen

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Remove second generic argument of StreamConsumer. Committed: https://code.google.com/p/dart/source/detail?r=21303

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -15 lines)			Patch
M	runtime/bin/socket_patch.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/async/stream.dart	View	3 chunks	+3 lines, -6 lines	0 comments	Download
M	sdk/lib/io/file_impl.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/io/http_impl.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/io/http_parser.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/io/io_sink.dart	View	4 chunks	+5 lines, -5 lines	0 comments	Download

Total messages: 5 (0 generated)

floitsch

Note: I haven't removed the generic type from IOSink. Should we do that too?

7 years, 8 months ago (2013-04-11 18:04:56 UTC) #1

Anders Johnsen

Yes, I think we should. We can always just 'override' in the classes implementing IOSink. ...

7 years, 8 months ago (2013-04-11 18:07:41 UTC) #2

floitsch

On 2013/04/11 18:07:41, Anders Johnsen wrote: > Yes, I think we should. We can always ...

7 years, 8 months ago (2013-04-11 18:09:06 UTC) #3

floitsch

7 years, 8 months ago (2013-04-11 18:11:59 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r21303 (presubmit successful).