Issue 1417163006: Fix three strong mode analysis issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1417163006: Fix three strong mode analysis issues. (Closed)

Created:
5 years, 1 month ago by devoncarew

Modified:
5 years, 1 month ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/pub_semver.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix three strong mode analysis issues. BUG=https://github.com/dart-lang/pub_semver/issues/10 R=nweiz@google.com Committed: https://github.com/dart-lang/pub_semver/commit/28902ddd16c3a769b692f92a2d653c71d91bef6e

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
M	CHANGELOG.md	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	lib/src/version_constraint.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/src/version_union.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	pubspec.yaml	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

devoncarew

Redux of https://codereview.chromium.org/1412633005/ (to workaround some local git issues).

5 years, 1 month ago (2015-10-30 22:42:22 UTC) #2

devoncarew

5 years, 1 month ago (2015-10-30 22:43:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
28902ddd16c3a769b692f92a2d653c71d91bef6e (presubmit successful).