Issue 141713013: pkg/unittest: tweaks to mock, re-enabled most tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 141713013: pkg/unittest: tweaks to mock, re-enabled most tests (Closed)

Created:
6 years, 10 months ago by kevmoo

Modified:
6 years, 10 months ago

Reviewers:
Bob Nystrom, Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

pkg/unittest: tweaks to mock, re-enabled most tests Flagged a failing test eliminate unused return values in core_matchers remove unused import Locking down Responder a bit adding toString to action more finals more better R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=32507

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -17 lines)			Patch
M	pkg/unittest/lib/html_enhanced_config.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/unittest/lib/mock.dart	View	6 chunks	+18 lines, -11 lines	0 comments	Download
M	pkg/unittest/lib/src/core_matchers.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/unittest/pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/unittest/test/mock_test.dart	View	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kevmoo

A solo_test snuck in, which disabled all but one test. There is still one broken ...

6 years, 10 months ago (2014-02-08 20:41:30 UTC) #1

kevmoo

6 years, 10 months ago (2014-02-10 18:16:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r32507 (presubmit successful).

Expand Messages | Collapse Messages