Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1004)

Issue 141713007: Revert "Infer types for compile-time constant closures." (Closed)

Created:
6 years, 10 months ago by floitsch
Modified:
6 years, 10 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Infer types for compile-time constant closures." This reverts commit r32276. Committed: https://code.google.com/p/dart/source/detail?r=32278

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -199 lines) Patch
M sdk/lib/_internal/compiler/implementation/inferrer/type_graph_inferrer.dart View 2 chunks +2 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/dart2js.status View 1 chunk +1 line, -2 lines 0 comments Download
D tests/compiler/dart2js/simple_inferrer_const_closure2_test.dart View 1 chunk +0 lines, -44 lines 0 comments Download
D tests/compiler/dart2js/simple_inferrer_const_closure3_test.dart View 1 chunk +0 lines, -44 lines 0 comments Download
D tests/compiler/dart2js/simple_inferrer_const_closure4_test.dart View 1 chunk +0 lines, -46 lines 0 comments Download
D tests/compiler/dart2js/simple_inferrer_global_field_closure_test.dart View 1 chunk +0 lines, -56 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
floitsch
TBR.
6 years, 10 months ago (2014-02-04 10:29:22 UTC) #1
floitsch
Committed patchset #1 manually as r32278 (presubmit successful).
6 years, 10 months ago (2014-02-04 10:29:51 UTC) #2
Johnni Winther
6 years, 10 months ago (2014-02-04 10:35:40 UTC) #3
Message was sent while issue was closed.
LGTM :(

Powered by Google App Engine
This is Rietveld 408576698