Generate unique names less aggressively.

Generate unique names less aggressively.


R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=21661

[Brian Wilkerson, 2013-04-18 00:00:32]

LGTM, although I didn't look at every line of every generated file.

https://codereview.chromium.org/14161021/diff/1/editor/util/plugins/com.googl...
File
editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/Context.java
(right):

https://codereview.chromium.org/14161021/diff/1/editor/util/plugins/com.googl...
editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/Context.java:221:
private String generateUniqueParameterName(Set<String> used, String name) {
There's probably a good reason for doing it this way that I'm just not thinking
of, but couldn't we start with 'name' and only add an index if there's a
collision? Seems like there won't be collisions very often except with field
names, but then the field names would already have to be prefixed by "this." in
the Java, so as long as we preserve that we should be fine.

[scheglov, 2013-04-18 00:08:27]

Committed patchset #1 manually as r21661 (presubmit successful).

[scheglov, 2013-04-18 00:09:51]

https://codereview.chromium.org/14161021/diff/1/editor/util/plugins/com.googl...
File
editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/Context.java
(right):

https://codereview.chromium.org/14161021/diff/1/editor/util/plugins/com.googl...
editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/Context.java:221:
private String generateUniqueParameterName(Set<String> used, String name) {
On 2013/04/18 00:00:32, Brian Wilkerson wrote:
> There's probably a good reason for doing it this way that I'm just not
thinking
> of, but couldn't we start with 'name' and only add an index if there's a
> collision? Seems like there won't be collisions very often except with field
> names, but then the field names would already have to be prefixed by "this."
in
> the Java, so as long as we preserve that we should be fine.

In general this is good idea, but in  this case we call this method when we
already identified that parameter name conflicts with its method name.

  void set period(Token period2) {
    this._period = period2;
  }