Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 14158003: Fix bug introduced by r21269. (Closed)

Created:
7 years, 8 months ago by Vyacheslav Egorov (Google)
Modified:
7 years, 8 months ago
Reviewers:
siva, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix bug introduced by r21269. PageSpace::LargePageSizeFor should not use sizeof(HeapPage) directly because real object start offset is additionally aligned. BUG= Committed: https://code.google.com/p/dart/source/detail?r=21276

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M runtime/vm/pages.h View 2 chunks +5 lines, -2 lines 0 comments Download
M runtime/vm/pages.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Vyacheslav Egorov (Google)
Please take a look. We should also consider moving LargePageSizeFor into the HeapPage itself because ...
7 years, 8 months ago (2013-04-11 12:59:05 UTC) #1
Vyacheslav Egorov (Google)
TBRing to extinguish the fire
7 years, 8 months ago (2013-04-11 13:06:47 UTC) #2
Vyacheslav Egorov (Google)
Committed patchset #1 manually as r21276 (presubmit successful).
7 years, 8 months ago (2013-04-11 13:08:22 UTC) #3
Vyacheslav Egorov (Google)
7 years, 8 months ago (2013-04-11 13:11:15 UTC) #4
Message was sent while issue was closed.
note: there is another use of sizeof(HeapPage)

  static const intptr_t kAllocatablePageSize = kPageSize - sizeof(HeapPage);

but it is safe.

I suggest we move all page size computations to the HeapPage itself.

Powered by Google App Engine
This is Rietveld 408576698