Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1333)

Issue 1415723007: SDK mocking for improved test throughput. (Closed)

Created:
5 years, 1 month ago by pquitslund
Modified:
5 years, 1 month ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/linter.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

SDK mocking for improved test throughput. Improves `all_test` execution from ~30 seconds to ~12. :) R=scheglov@google.com Committed: https://github.com/dart-lang/linter/commit/567106946da17cfbcbc8f3227a78874bcf7b50c4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+441 lines, -11 lines) Patch
M lib/src/analysis.dart View 4 chunks +14 lines, -5 lines 0 comments Download
M lib/src/linter.dart View 1 chunk +0 lines, -3 lines 0 comments Download
A lib/src/sdk.dart View 1 chunk +421 lines, -0 lines 0 comments Download
M test/rule_test.dart View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
pquitslund
5 years, 1 month ago (2015-11-03 21:07:42 UTC) #2
scheglov
LGTM
5 years, 1 month ago (2015-11-03 21:09:18 UTC) #3
pquitslund
5 years, 1 month ago (2015-11-03 21:09:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
567106946da17cfbcbc8f3227a78874bcf7b50c4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698