Optmize detached socket to not contain a extra stream controller/subscription, but simly forward ca…

Optmize detached socket to not contain a extra stream controller/subscription, but simly forward callbacks (and inject potential extra data).

BUG=
R=sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32277

[Søren Gjesse, 2014-02-04 10:17:24]

lgtm, with comments - pretty hairy stuff!

https://codereview.chromium.org/141553014/diff/1/sdk/lib/io/http_parser.dart
File sdk/lib/io/http_parser.dart (right):

https://codereview.chromium.org/141553014/diff/1/sdk/lib/io/http_parser.dart#...
sdk/lib/io/http_parser.dart:99: 
Please add a short description of this subscription class.

https://codereview.chromium.org/141553014/diff/1/sdk/lib/io/http_parser.dart#...
sdk/lib/io/http_parser.dart:101: StreamSubscription<List<int>> _subscription;
Can we find a better name that _data? It is pretty generic.

https://codereview.chromium.org/141553014/diff/1/sdk/lib/io/http_parser.dart#...
sdk/lib/io/http_parser.dart:155: void _scheduleData() {
This method does not necessarily schedule the data, so it should be called
something like _maybeScheduleData.

https://codereview.chromium.org/141553014/diff/1/sdk/lib/io/http_parser.dart#...
sdk/lib/io/http_parser.dart:163: _data = null;
Please add a comment here on why the underlying subscription is resumed before
sending the cached data.

[Anders Johnsen, 2014-02-04 10:24:51]

https://codereview.chromium.org/141553014/diff/1/sdk/lib/io/http_parser.dart
File sdk/lib/io/http_parser.dart (right):

https://codereview.chromium.org/141553014/diff/1/sdk/lib/io/http_parser.dart#...
sdk/lib/io/http_parser.dart:99: 
On 2014/02/04 10:17:24, Søren Gjesse wrote:
> Please add a short description of this subscription class.

Done.

https://codereview.chromium.org/141553014/diff/1/sdk/lib/io/http_parser.dart#...
sdk/lib/io/http_parser.dart:101: StreamSubscription<List<int>> _subscription;
On 2014/02/04 10:17:24, Søren Gjesse wrote:
> Can we find a better name that _data? It is pretty generic.

Done.

https://codereview.chromium.org/141553014/diff/1/sdk/lib/io/http_parser.dart#...
sdk/lib/io/http_parser.dart:155: void _scheduleData() {
On 2014/02/04 10:17:24, Søren Gjesse wrote:
> This method does not necessarily schedule the data, so it should be called
> something like _maybeScheduleData.

Done.

https://codereview.chromium.org/141553014/diff/1/sdk/lib/io/http_parser.dart#...
sdk/lib/io/http_parser.dart:163: _data = null;
On 2014/02/04 10:17:24, Søren Gjesse wrote:
> Please add a comment here on why the underlying subscription is resumed before
> sending the cached data.

Done.

[Anders Johnsen, 2014-02-04 10:27:49]

Committed patchset #2 manually as r32277 (presubmit successful).