Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issue 14155002: Fix apidoc dependencies and reenable editor test (Closed)

Created:
7 years, 8 months ago by ricow1
Modified:
7 years, 8 months ago
Reviewers:
ahe, Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix apidoc dependencies and reenable editor test Add back full copy of lib/_internal Also fix snapshot dependency on old dart2js snapshot location Committed: https://code.google.com/p/dart/source/detail?r=21257

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/dartdoc/DartdocGeneratorTest.java View 1 chunk +1 line, -1 line 0 comments Download
M tools/create_sdk.py View 2 chunks +1 line, -6 lines 0 comments Download
M utils/apidoc/apidoc.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
ricow1
7 years, 8 months ago (2013-04-11 07:42:36 UTC) #1
Mads Ager (google)
LGTM
7 years, 8 months ago (2013-04-11 07:46:37 UTC) #2
ricow1
Committed patchset #1 manually as r21257 (presubmit successful).
7 years, 8 months ago (2013-04-11 07:47:25 UTC) #3
ahe
7 years, 8 months ago (2013-04-11 08:49:00 UTC) #4
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698