Issue 141523008: Revert "Redo "Make dart2js typed_data implementation classes private""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 141523008: Revert "Redo "Make dart2js typed_data implementation classes private"" (Closed)

Created:
6 years, 11 months ago by sra1

Modified:
6 years, 11 months ago

Reviewers:

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Redo "Make dart2js typed_data implementation classes private"" Revert while I figure out the correct analyzer suppression. BUG= Committed: https://code.google.com/p/dart/source/detail?r=31933

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+665 lines, -1185 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/compiler.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/elements/elements.dart	View	1 chunk	+6 lines, -10 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/inferrer/simple_types_inferrer.dart	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/native_handler.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/libraries.dart	View	2 chunks	+1 line, -7 lines	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View	4 chunks	+4 lines, -5 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/html/html_common/conversions.dart	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	sdk/lib/html/html_common/html_common_dart2js.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	sdk/lib/typed_data/dart2js/native_typed_data_dart2js.dart	View	1 chunk	+0 lines, -970 lines	0 comments	Download
M	sdk/lib/typed_data/dart2js/typed_data_dart2js.dart	View	49 chunks	+619 lines, -130 lines	0 comments	Download
M	sdk/lib/web_audio/dart2js/web_audio_dart2js.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sdk/lib/web_gl/dart2js/web_gl_dart2js.dart	View	4 chunks	+6 lines, -7 lines	0 comments	Download
M	tests/co19/co19-dart2dart.status	View	1 chunk	+0 lines, -16 lines	0 comments	Download
M	tools/dom/scripts/dartmetadata.py	View	4 chunks	+15 lines, -17 lines	0 comments	Download
M	tools/dom/templates/html/dart2js/html_dart2js.darttemplate	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/dom/templates/html/dart2js/indexed_db_dart2js.darttemplate	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/dom/templates/html/dart2js/web_audio_dart2js.darttemplate	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/dom/templates/html/dart2js/web_gl_dart2js.darttemplate	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

sra1

6 years, 11 months ago (2014-01-17 21:54:31 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r31933 (presubmit successful).

Expand Messages | Collapse Messages