Issue 1415223004: Use the async package's new RestartableTimer class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1415223004: Use the async package's new RestartableTimer class. (Closed)

Created:
5 years, 1 month ago by nweiz

Modified:
5 years, 1 month ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/pool@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Use the async package's new RestartableTimer class. R=rnystrom@google.com Committed: https://github.com/dart-lang/pool/commit/7079610491787a1c58651e4dab3a71a5199aa0cb

Patch Set 1 #

Total comments: 2

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -13 lines)			Patch
M	CHANGELOG.md	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	lib/pool.dart	View	3 chunks	+20 lines, -11 lines	2 comments	Download
M	pubspec.yaml	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

One suggestion but LGTM! https://codereview.chromium.org/1415223004/diff/1/lib/pool.dart File lib/pool.dart (right): https://codereview.chromium.org/1415223004/diff/1/lib/pool.dart#newcode81 lib/pool.dart:81: _timer = new RestartableTimer(timeout, _onTimeout)..cancel(); ...

5 years, 1 month ago (2015-10-28 21:40:27 UTC) #2

nweiz

Committed patchset #1 (id:1) manually as 7079610491787a1c58651e4dab3a71a5199aa0cb (presubmit successful).

5 years, 1 month ago (2015-10-28 21:47:35 UTC) #3

nweiz

5 years, 1 month ago (2015-10-28 21:47:36 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/1415223004/diff/1/lib/pool.dart
File lib/pool.dart (right):

https://codereview.chromium.org/1415223004/diff/1/lib/pool.dart#newcode81
lib/pool.dart:81: _timer = new RestartableTimer(timeout, _onTimeout)..cancel();
On 2015/10/28 21:40:27, Bob Nystrom wrote:
> "cancel" is a weird name for this. To me, it implies finality. Would "stop"
make
> more sense?

It's an inherited name from Timer. I wanted to keep the APIs as similar as
possible for familiarity (and in fact RestartableTimer implements Timer).

Expand Messages | Collapse Messages